This repository was archived by the owner on Feb 13, 2026. It is now read-only.
feat: remove _ClientFactoryMixin#305
Closed
rinarakaki wants to merge 2 commits intogoogleapis:mainfrom
rinarakaki:remove-_ClientFactoryMixin
Closed
feat: remove _ClientFactoryMixin#305rinarakaki wants to merge 2 commits intogoogleapis:mainfrom rinarakaki:remove-_ClientFactoryMixin
rinarakaki wants to merge 2 commits intogoogleapis:mainfrom
rinarakaki:remove-_ClientFactoryMixin
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a private class and inherited only by
Clientclass, so I simply implemented those methods forClient, removing the ambiguity of arguments*argsand**kwargs.This makes it way easier to add type hints later (#302).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕